Skip to content

TSQL: adds drop and add period to alter table #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

TSQL: adds drop and add period to alter table #6590

merged 1 commit into from
Jan 23, 2025

Conversation

nathanthorell
Copy link
Contributor

@nathanthorell nathanthorell commented Jan 23, 2025 •
edited
Loading

Brief summary of the change made

fixes #6585

ALTER TABLE has both a DROP PERIOD and ADD PERIOD for Temporal Tables. This change adds that to the AlterTableStatementSegment.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@nathanthorell nathanthorell changed the title Add tsql drop and add period TSQL: add drop and add period to alter table Jan 23, 2025
@nathanthorell nathanthorell changed the title TSQL: add drop and add period to alter table TSQL: adds drop and add period to alter table Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19223      0   100%

248 files skipped due to complete coverage.

keraion
keraion approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@keraion keraion added this pull request to the merge queue Jan 23, 2025
Merged via the queue into sqlfluff:main with commit 3527021 Jan 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSQL Alter Table unparsable error for DROP PERIOD
2 participants
@nathanthorell @keraion