Skip to content

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jan 21, 2025

Brief summary of the change made

This fixes a number of issues with ST05:

  • Conflicts with other rules such as ST06, LT08, and LT09
  • Supports the CTE spacing with LT08 on the first pass
  • The handling of orders on some fixes
  • Allowed for partial fixes when some aliases had the same name

Linked Issues:

Are there any other side effects of this change that we should be aware of?

None, but this does make ST05 use the BaseSegment._position_segments which is maybe less than ideal.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19226      0   100%

248 files skipped due to complete coverage.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge PR - makes sense to me

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit 7afceee Jan 25, 2025
31 checks passed
@WittierDinosaur WittierDinosaur deleted the ST05_order_conflicts branch January 25, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants