Skip to content

Conversation

boushphong
Copy link
Contributor

@boushphong boushphong commented Jan 14, 2025

Brief summary of the change made

Why

  • These missing functions will break the linting even even when we configure apply_dbt_builtins=true

How to reproduce

sqlfluff lint --templater=jinja --dialect bigquery --ignore="templating, parsing" -<<EOF
{% set cols = ['c1', 'c2', 'c3'] %}
{% set tables = ['alice', 'bob', 'tim'] %}

{% for (c, t) in zip(cols, tables) %}
select
  {{ c }} as col
from
  {{ t }}
{% if not loop.last %}
  union all
{% endif %}
{% endfor %}
EOF

This will throw a ValueError because zip is not a built-in jinja2 function.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19263      0   100%

248 files skipped due to complete coverage.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for these? In test/fixtures/templater/

@boushphong boushphong force-pushed the add_zip_dbt_jinj2_func branch from 0ce9d6d to ce09109 Compare January 26, 2025 10:06
@boushphong
Copy link
Contributor Author

Can you add some tests for these? In test/fixtures/templater/

@WittierDinosaur Done! sir

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jan 26, 2025
Merged via the queue into sqlfluff:main with commit 96bafc1 Jan 26, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants