Add support for PostGIS geometry(point) datatype.
#6543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Results ✅ |
keraion
reviewed
Jan 15, 2025
| "POINT", | ||
| Sequence( | ||
| OneOf(*_geometry_type_keywords, "GEOMETRY", "GEOGRAPHY"), | ||
| Ref("CommaSegment"), |
There was a problem hiding this comment.
I am by no means an expert on postgis, but it might make more sense to make the comma and numeric literal (the SRID) an optional sequence instead.
There was a problem hiding this comment.
Changed to be an optional sequence.
keraion
reviewed
Jan 24, 2025
Comment on lines
1504
to
1513
| OneOf( | ||
| "POINT", | ||
| Sequence( | ||
| OneOf(*_geometry_type_keywords, "GEOMETRY", "GEOGRAPHY"), | ||
| Sequence( | ||
| Ref("CommaSegment"), | ||
| Ref("NumericLiteralSegment"), | ||
| optional=True, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
I think this can be further simplified because POINT is in the _geometry_type_keywords
Suggested change
| OneOf( | |
| "POINT", | |
| Sequence( | |
| OneOf(*_geometry_type_keywords, "GEOMETRY", "GEOGRAPHY"), | |
| Sequence( | |
| Ref("CommaSegment"), | |
| Ref("NumericLiteralSegment"), | |
| optional=True, | |
| ), | |
| ), | |
| Sequence( | |
| OneOf(*_geometry_type_keywords, "GEOMETRY", "GEOGRAPHY"), | |
| Sequence( | |
| Ref("CommaSegment"), | |
| Ref("NumericLiteralSegment"), | |
| optional=True, | |
| ), | |
| ), |
There was a problem hiding this comment.
My bad. I refactored now.
keraion
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6351.
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.