Skip to content

Snowflake: Support PARTITION_TYPE for CREATE EXTERNAL TABLE #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 2, 2024
Merged

Snowflake: Support PARTITION_TYPE for CREATE EXTERNAL TABLE #6422

merged 5 commits into from
Nov 2, 2024

Conversation

ninazacharia-toast
Copy link
Contributor

@ninazacharia-toast ninazacharia-toast commented Nov 1, 2024 •
edited
Loading

Brief summary of the change made

fixes #6420

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@ninazacharia-toast ninazacharia-toast changed the title add partition_type Snowflake: Support PARTITION_TYPE for CREATE EXTERNAL TABLE Nov 1, 2024
@ninazacharia-toast ninazacharia-toast marked this pull request as ready for review November 1, 2024 21:10
greg-finley
greg-finley approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@greg-finley greg-finley enabled auto-merge November 2, 2024 05:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18688      0   100%

239 files skipped due to complete coverage.

@greg-finley greg-finley added this pull request to the merge queue Nov 2, 2024
Merged via the queue into sqlfluff:main with commit 6b8faf8 Nov 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling of PARTITION_TYPE in CREATE EXTERNAL TABLE parameters in Snowflake dialect
2 participants
@ninazacharia-toast @greg-finley