Skip to content

Databricks: Parse Table Valued Functions #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2024
Merged

Databricks: Parse Table Valued Functions #6417

merged 4 commits into from
Nov 2, 2024

Conversation

fstg1992
Copy link
Contributor

@fstg1992 fstg1992 commented Nov 1, 2024 •
edited
Loading

  • added table valued function parsing

Brief summary of the change made

  • Added support to databricks dialect to allow parsing table valued functions
  • Added test cases

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Fritz Steingrube added 2 commits November 1, 2024 12:58
parse table valued functions
b2d1436 
* added table valued function parsing
added comment to test
54c1fef
@fstg1992 fstg1992 changed the title Databricks : Parse Table Valued Functions added to Dialect Databricks: Parse Table Valued Functions Nov 1, 2024
@fstg1992 fstg1992 marked this pull request as ready for review November 1, 2024 12:14
WittierDinosaur
WittierDinosaur approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur
Copy link
Contributor

Linting tests are failing, please run black

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18688      0   100%

239 files skipped due to complete coverage.

auto-merge was automatically disabled November 1, 2024 15:44

Head branch was pushed to by a user without write access

@fstg1992
Copy link
Contributor Author

fstg1992 commented Nov 1, 2024

done.

@greg-finley greg-finley enabled auto-merge November 2, 2024 05:08
@greg-finley greg-finley added this pull request to the merge queue Nov 2, 2024
Merged via the queue into sqlfluff:main with commit 51e8cf4 Nov 2, 2024
27 of 28 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@fstg1992
Issue #6417: Leading -- MAGIC Cells don't break parsing of notebooks (#…
391449e 
…6454)

Co-authored-by: F STG <fritz.steingrube@extern.stromnetz-hamburg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fstg1992 @WittierDinosaur @greg-finley