Skip to content

Snowflake: alter table on delete and update support #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2024
Merged

Snowflake: alter table on delete and update support #6473

merged 4 commits into from
Dec 3, 2024

Conversation

WobblyRobbly
Copy link
Contributor

@WobblyRobbly WobblyRobbly commented Nov 27, 2024 •
edited by WittierDinosaur
Loading

Brief summary of the change made

This change allows for Snowflake ALTER TABLE to define a FOREIGN KEY that has uses the ON DELETE / ON UPDATE

Fixes #6472

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • [ *] Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@WittierDinosaur WittierDinosaur changed the title fixes #6472: snowflake alter table on delete and update support Snowflake: alter table on delete and update support Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18849      0   100%

244 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Dec 3, 2024
Merged via the queue into sqlfluff:main with commit 83a404a Dec 3, 2024
28 of 29 checks passed
@WobblyRobbly WobblyRobbly mentioned this pull request Dec 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

@WittierDinosaur WittierDinosaur Awaiting requested review from WittierDinosaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake ForeignKey constraint ON DELETE not recognised
4 participants
@WobblyRobbly @alanmcruickshank @WittierDinosaur @jlp-robs