Skip to content

Teradata: support REPLACE VIEW and LOCKING ... FOR ... syntax #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 25, 2024
Merged

Teradata: support REPLACE VIEW and LOCKING ... FOR ... syntax #6467

merged 7 commits into from
Nov 25, 2024

Conversation

V-D-L-P
Copy link
Contributor

@V-D-L-P V-D-L-P commented Nov 21, 2024 •
edited
Loading

Brief summary of the change made

Add missing Teradata syntax support:

  • View creation using the REPLACE keyword
  • LOCKING ... FOR ... statements preceding SELECT or WITH...SELECT clauses

Are there any other side effects of this change that we should be aware of?

No side effect identified, the rest of the syntax is still the one from ansi, added LOCKING statement is always optional.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18800      0   100%

243 files skipped due to complete coverage.

@V-D-L-P V-D-L-P changed the title Teradata: support REPLACE VIEW syntax Teradata: support REPLACE VIEW and LOCKING ... FOR ... syntax Nov 23, 2024
alanmcruickshank
alanmcruickshank approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Nov 25, 2024
Merged via the queue into sqlfluff:main with commit 8e26bd4 Nov 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V-D-L-P @alanmcruickshank