Skip to content

Bigquery: Support column level key definitions #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Bigquery: Support column level key definitions #6465

merged 1 commit into from
Nov 21, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Nov 20, 2024

Brief summary of the change made

This allows for the column level definition for a key constraint e.g. PRIMARY KEY NOT ENFORCED or REFERENCES table_name(column_name) NOT ENFORCED

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18776      0   100%

243 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 65ef3d0 Nov 21, 2024
31 checks passed
@alanmcruickshank alanmcruickshank deleted the bigquery_column_key_not_enforced branch November 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery dialect fails to parse PRIMARY KEY NOT ENFORCED
2 participants
@keraion @alanmcruickshank