Skip to content

fixes #6463: Set Variable Parsing for SparkSQL and Databricks #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 25, 2024
Merged

fixes #6463: Set Variable Parsing for SparkSQL and Databricks #6464

merged 7 commits into from
Nov 25, 2024

Conversation

fstg1992
Copy link
Contributor

@fstg1992 fstg1992 commented Nov 19, 2024 •
edited
Loading

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@fstg1992 fstg1992 marked this pull request as ready for review November 19, 2024 12:06
WittierDinosaur
WittierDinosaur reviewed Nov 19, 2024
View reviewed changes
WittierDinosaur
WittierDinosaur reviewed Nov 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18799      0   100%

243 files skipped due to complete coverage.

@fstg1992 fstg1992 changed the title Issue #6463 - Set Variable Parsing for SparkSQL and Databricks fixes #6463 - Set Variable Parsing for SparkSQL and Databricks Nov 19, 2024
@fstg1992 fstg1992 changed the title fixes #6463 - Set Variable Parsing for SparkSQL and Databricks fixes #6463: Set Variable Parsing for SparkSQL and Databricks Nov 19, 2024
alanmcruickshank
alanmcruickshank reviewed Nov 21, 2024
View reviewed changes
alanmcruickshank
alanmcruickshank approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Nov 25, 2024
Merged via the queue into sqlfluff:main with commit 7783c30 Nov 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur left review comments

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Databricks Dialect: Set variable x = select y from z unparsable
3 participants
@fstg1992 @alanmcruickshank @WittierDinosaur