Skip to content

Conversation

fstg1992
Copy link
Contributor

Brief summary of the change made

Added a workaround to Databricks Dialect to allow for parsing of -- MAGIC Cells in SQL-Notebooks.
-- MAGIC Cells are now treated as their own statement block, even though they're technically comments, in order to avoid conflict with the statement terminator -- COMMAND -------. (described in detail in the issue)

Are there any other side effects of this change that we should be aware of?

Comments matching a very particular format may now be parsed as statement. Should not be a major risk, as the regular format of these blocks is simply an inline comment.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

F STG and others added 3 commits November 13, 2024 17:19
* new tests
* new grammar + segments for dbrks notebook parsing
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18770      0   100%

243 files skipped due to complete coverage.

@fstg1992 fstg1992 marked this pull request as ready for review November 13, 2024 16:40
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Nov 13, 2024
Merged via the queue into sqlfluff:main with commit 391449e Nov 13, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Databricks Notebook Parsing: Parser fails on leading Markdown cell
2 participants