Skip to content

Postgres: Add CREATE FOREIGN DATA WRAPPER statement #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

Postgres: Add CREATE FOREIGN DATA WRAPPER statement #6335

merged 2 commits into from
Oct 11, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Oct 11, 2024

Brief summary of the change made

This adds the CREATE FOREIGN DATA WRAPPER statement for the postgres_fdw extension.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18568      0   100%

236 files skipped due to complete coverage.

greg-finley
greg-finley reviewed Oct 11, 2024
View reviewed changes
src/sqlfluff/dialects/dialect_postgres.py Outdated
"FOREIGN",
"DATA",
"WRAPPER",
Ref("WrapperReferenceSegment"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, but I'm curious why we need to define WrapperReferenceSegment and the other two instead of just directly using SingleIdentifierGrammar? Would the formatting be any different? Is it worth maintaining the extra code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I've simplified it now.

greg-finley
greg-finley approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@greg-finley greg-finley enabled auto-merge October 11, 2024 18:14
@greg-finley greg-finley added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 1007f00 Oct 11, 2024
30 checks passed
@greg-finley greg-finley deleted the postgres_create_foreign_wrapper branch October 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error raised by supabase stripe datawrapper
2 participants
@keraion @greg-finley