Skip to content

TSQL: handle nested joins, RF01 better aliasing #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

TSQL: handle nested joins, RF01 better aliasing #6300

merged 1 commit into from
Oct 6, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Oct 6, 2024

Brief summary of the change made

This adds supported for bracketed nested joins in tsql.
Also fixes how aliases of bracketed table_expression detect aliases

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18458      0   100%

236 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit 057972b Oct 6, 2024
29 checks passed
@WittierDinosaur WittierDinosaur deleted the tsql_nested_table_expressions branch October 6, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parentheses in nested JOINs in FROM clause causes unparseable section errors with tsql dialect
2 participants
@keraion @WittierDinosaur