Switch from appdirs to platformdirs
#6399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Results ✅ |
|
Thank you already. The original patch was imported in Debian (with this one failing test disabled) |
My pleasure! This one should be almost ready to go. |
greg-finley
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #6238. Switches from
appdirs(which isn't maintained anymore) toplatformdirs.This however involves revisiting our XDG hack. The original test cases weren't very robust, and so a big chunk of this PR is actually making the test cases better (and work with
platform_dirs). Coverage is painful here, but I think the approach I've settled on works out ok.I've added a chunk more comments and docstrings too to help with making it clearer.