Skip to content

TSQL: add missing unreserved keyword NULLS (#5212) #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

TSQL: add missing unreserved keyword NULLS (#5212) #6390

merged 1 commit into from
Oct 24, 2024

Conversation

simonhoerdumbonde
Copy link
Contributor

Brief summary of the change made

Adding the unreserved keyword NULLS to the TSQL dialect. Fixes #5212

alanmcruickshank
alanmcruickshank approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for the contribution!

This looks good to me. Assuming tests pass, it should be good to merge.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18625      0   100%

236 files skipped due to complete coverage.

Merged via the queue into sqlfluff:main with commit 8c63de4 Oct 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore nulls / respect nulls not recognised in tsql dialect
2 participants
@simonhoerdumbonde @alanmcruickshank