Skip to content

Fix edge case in Jinja reindents #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix edge case in Jinja reindents #6383

merged 1 commit into from
Oct 22, 2024

Conversation

rogalski
Copy link
Contributor

Brief summary of the change made

Fixes #6378

Are there any other side effects of this change that we should be aware of?

Hopefully not.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18625      0   100%

236 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for this. Great to have someone else digging into the indentation logic.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 22, 2024
Merged via the queue into sqlfluff:main with commit 6933818 Oct 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LT02 ValueError: max() arg is an empty sequence (Jinja templater)
2 participants
@rogalski @alanmcruickshank