Skip to content

SparkSQL: Improved lexing and parsing of file literals #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2024
Merged

SparkSQL: Improved lexing and parsing of file literals #6375

merged 3 commits into from
Oct 20, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Oct 20, 2024

Brief summary of the change made

This prevents some segments that use division without spaces from being lexed as a file_literal.

Are there any other side effects of this change that we should be aware of?

This changes the file_literal to have some sub-parts namely path_segment and slash (taken from the clickhouse dialect). This shouldn't have any impact but changes the parsing tree.
Also slash now allows for any layout for before and after spacing as we shouldn't manipulate the filepath.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@keraion
SparkSQL: improved lexing and parsing of file literals
41600f8 
  This prevents some segments that use division without spaces from
  being lexed as a file_literal
@keraion
add test for LT01 and slashes
c2290ec
@keraion
Reword file_literal docstring
91923f3
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18608      0   100%

236 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 20, 2024
Merged via the queue into main with commit cc2be14 Oct 20, 2024
30 checks passed
@alanmcruickshank alanmcruickshank deleted the sparksql_file_literal_improvements branch October 20, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sparksql] column parsing exception when select field contains consecutive division operations
2 participants
@keraion @alanmcruickshank