Skip to content

Conversation

mroy-seedbox
Copy link
Contributor

Brief summary of the change made

Make the dbt RelationEmulator safely callable.

Fixes #6357.

Are there any other side effects of this change that we should be aware of?

No.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18583      0   100%

236 files skipped due to complete coverage.

@mroy-seedbox
Copy link
Contributor Author

Hmmm.... I'm not sure how to update the fixtures for test/fixtures/templater/jinja_c_dbt/dbt_builtins_this.sql... 🤔

I did tox -e generate-fixture-yml, but that didn't work. Looks like it only updates the fixtures for the various dialects. 😞

@mroy-seedbox
Copy link
Contributor Author

Alright, this is ready! 🚀

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 15, 2024
Merged via the queue into sqlfluff:main with commit 50420fb Oct 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecoverable failure in Jinja templating: RelationEmulator is not safely callable.
2 participants