Skip to content

tsql: allow both on delete and on update in a reference_constraint #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

tsql: allow both on delete and on update in a reference_constraint #6346

merged 1 commit into from
Oct 13, 2024
+53 −7

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Oct 13, 2024 •
edited
Loading

Brief summary of the change made

This allows for both ON DELETE and ON UPDATE to exist on a single reference_constraint_grammar for tsql.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18572      0   100%

236 files skipped due to complete coverage.

@greg-finley greg-finley added this pull request to the merge queue Oct 13, 2024
Merged via the queue into main with commit 0bc27a0 Oct 13, 2024
30 checks passed
@greg-finley greg-finley deleted the tsql_on_update_delete branch October 13, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tsql] Including both ON UPDATE CASCADE and ON DELETE CASCADE causes PRS ("Found unparsable section")
2 participants
@keraion @greg-finley