Skip to content

Conversation

R3gardless
Copy link
Contributor

@R3gardless R3gardless commented Oct 12, 2024

Brief summary of the change made

This code snippet bypasses the RF05 rule for PostgreSQL dialects when an extension_reference type is detected in the parent stack. If the current SQL dialect is PostgreSQL and the parent stack contains an extension_reference, the function will return None, effectively ignoring the RF05 rule in this specific context.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    test_pass_create_extension_reference_quoted:
      pass_str: CREATE EXTENSION IF NOT EXISTS "quoted-extension";
      configs:
        core:
          dialect: postgres
    
    test_pass_drop_extension_reference_quoted:
      pass_str: DROP EXTENSION IF EXISTS "quoted-extension";
      configs:
        core:
          dialect: postgres
    
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

github-actions bot commented Oct 12, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18572      0   100%

236 files skipped due to complete coverage.

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for the contribution!

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 12, 2024
Merged via the queue into sqlfluff:main with commit 70d4060 Oct 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use special characters in identifiers. create extension "uuid-ossp"; (postgres)
2 participants