Skip to content

Fix time travel clauses in Snowflake dialect #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix time travel clauses in Snowflake dialect #6230

merged 1 commit into from
Sep 20, 2024

Conversation

fpsebastiam
Copy link
Contributor

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

WittierDinosaur
WittierDinosaur approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18339      0   100%

236 files skipped due to complete coverage.

Merged via the queue into sqlfluff:main with commit 9f0e3d9 Sep 20, 2024
27 checks passed
@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 2ec763b on fpsebastiam:fix-time-travel-in-snowflake
into 2605df0 on sqlfluff:main.

@keraion keraion mentioned this pull request Oct 11, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[snowflake] time travel using AT | BEFORE clause
3 participants
@fpsebastiam @coveralls @WittierDinosaur