Skip to content

fix: complex file extensions discovery #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: complex file extensions discovery #6228

merged 2 commits into from
Sep 23, 2024

Conversation

Clepech
Copy link
Contributor

@Clepech Clepech commented Sep 20, 2024

Brief summary of the change made

Make file with extension compose of multiple part (eg .sql.j2) discoverable by sqlfluff (again)

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

alanmcruickshank
alanmcruickshank approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sensible. Thanks for the neat and minimal PR. 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18357      0   100%

237 files skipped due to complete coverage.

@coveralls
Copy link

coveralls commented Sep 23, 2024 •
edited
Loading

Coverage Status

coverage: 99.985%. remained the same
when pulling b7171c0 on Clepech:fix/cannot_find_ext_with_multiple_parts
into 49ceab1 on sqlfluff:main.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Sep 23, 2024
Merged via the queue into sqlfluff:main with commit 0cc067c Sep 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find files with complex extensions
3 participants
@Clepech @coveralls @alanmcruickshank