Skip to content

Bugfix for LT07 with consumed newlines. #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Bugfix for LT07 with consumed newlines. #6294

merged 1 commit into from
Oct 4, 2024
+39 −0

Conversation

alanmcruickshank
Copy link
Member

I noticed that LT07 is throwing false positives if a CTE ends with a whitespace-consuming jinja tag. this adds logic to handle that situation and react accordingly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18411      0   100%

236 files skipped due to complete coverage.

keraion
keraion approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keraion keraion added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit e7b7af6 Oct 4, 2024
29 checks passed
@keraion keraion deleted the ac/bugfix_3 branch October 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

@greg-finley greg-finley Awaiting requested review from greg-finley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanmcruickshank @keraion