Skip to content

Test dbt Templater Plugin with dbt 1.9.0 #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

Test dbt Templater Plugin with dbt 1.9.0 #6280

merged 1 commit into from
Oct 2, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Oct 1, 2024 •
edited
Loading

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@edgarrmondragon edgarrmondragon force-pushed the test-dbt-1.9 branch 2 times, most recently from 86072b0 to cc95c92 Compare October 1, 2024 19:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18406      0   100%

236 files skipped due to complete coverage.

@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Coverage Status

coverage: 99.985%. remained the same
when pulling 8614247 on edgarrmondragon:test-dbt-1.9
into 99b3f92 on sqlfluff:main.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 1, 2024 19:59
@edgarrmondragon edgarrmondragon changed the title Test with dbt 1.9.0 Test dbt Templater Plugin with dbt 1.9.0 Oct 1, 2024
greg-finley
greg-finley approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@greg-finley greg-finley added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 2, 2024
Merged via the queue into sqlfluff:main with commit 8f26aa0 Oct 2, 2024
28 checks passed
@edgarrmondragon edgarrmondragon deleted the test-dbt-1.9 branch October 2, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarrmondragon @coveralls @greg-finley @alanmcruickshank