Skip to content

RF05: Add table_aliases option #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 4, 2024
Merged

RF05: Add table_aliases option #6273

merged 7 commits into from
Oct 4, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Sep 30, 2024

Brief summary of the change made

This adds support for checking special characters only in table aliases in RF05.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18408      0   100%

236 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 2925681 on RF05_table_aliases
into 158054c on main.

@alanmcruickshank
Copy link
Member

Something really strange here has gone on with the yaml file indentation. I'll see if I can resolve it.

alanmcruickshank
alanmcruickshank approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 8251ffc Oct 4, 2024
29 checks passed
@alanmcruickshank alanmcruickshank deleted the RF05_table_aliases branch October 4, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule references.special_chars ignores quoted_identifiers_policy
3 participants
@keraion @coveralls @alanmcruickshank