Skip to content

DuckDB: Add DROP MACRO #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

DuckDB: Add DROP MACRO #6270

merged 1 commit into from
Sep 28, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Sep 28, 2024

Brief summary of the change made

This adds the DROP MACRO and DROP FUNCTION statement to the DuckDB dialect.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18365      0   100%

237 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 6b8b676 on duckdb_drop_macro
into d2c94a0 on main.

alanmcruickshank
alanmcruickshank approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit 98cd54f Sep 28, 2024
29 checks passed
@alanmcruickshank alanmcruickshank deleted the duckdb_drop_macro branch September 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"drop macro" unparsable (DuckDB)
3 participants
@keraion @coveralls @alanmcruickshank