Skip to content

Added Support for Databricks SQL Notebook Cells #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2024
Merged

Added Support for Databricks SQL Notebook Cells #6267

merged 2 commits into from
Sep 27, 2024

Conversation

gabepesco
Copy link
Contributor

@gabepesco gabepesco commented Sep 27, 2024 •
edited
Loading

Brief summary of the change made

fixes #6222

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

  • Added appropriate documentation for the change.

alanmcruickshank
alanmcruickshank approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Assuming tests pass, I think this is good to go. 👍

Thanks for the contribution.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18363      0   100%

237 files skipped due to complete coverage.

@coveralls
Copy link

coveralls commented Sep 27, 2024 •
edited
Loading

Coverage Status

coverage: 99.985%. remained the same
when pulling 8f7f2b5 on gabepesco:feature/6222-databricks-notebook-cells
into b75f511 on sqlfluff:main.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Sep 27, 2024
Merged via the queue into sqlfluff:main with commit d2c94a0 Sep 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Databricks SQL notebook source file
3 participants
@gabepesco @coveralls @alanmcruickshank