Move most of the config validation settings out into rule bundles. #6262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Results ✅ |
keraion
reviewed
Sep 28, 2024
test/core/rules/rules_test.py
Outdated
| new_rule = Rule_NewRule_ZZ99(code="L000", description="", tab_space_size=6) | ||
| assert new_rule.tab_space_size == 6 | ||
| new_rule = Rule_NewRule_ZZ99(code="L000", description="", case_sensitive=False) | ||
| assert new_rule.case_sensitive is False | ||
| # Error is thrown since "tab_space_size" is defined in class, |
There was a problem hiding this comment.
Comment here referencing tab_space_size should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that while most of the rules are defined in plugin bundles now (and therefore outside of the core package), and that there's a plugin hook for importing config validation values - none of the bundles use it, and instead all the config validation settings are still centrally defined.
This moves most of them out into the rule bundles, for better isolation, and not better mimic how external plugin maintainers should structure their projects.
I also removed the validation for any config values which are no longer valid to have on rules.