Fix spacing rules for functions #5809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WittierDinosaur
commented
Apr 24, 2024
WittierDinosaur
commented
Apr 24, 2024
WittierDinosaur
commented
Aug 24, 2024
…res-bare-function-spacing
Coverage Results ✅ |
keraion
reviewed
Aug 26, 2024
| optional=True, | ||
| ), | ||
| ), | ||
| # parse_mode=ParseMode.GREEDY, |
There was a problem hiding this comment.
Commented line can be removed.
There was a problem hiding this comment.
agreed on these, will sort tomorrow
|
|
||
| type = "function_contents" | ||
|
|
||
| match_grammar = Sequence( |
There was a problem hiding this comment.
nit: Sequence is not required here.
There was a problem hiding this comment.
Interesting quirk that we should probably fix. You cannot start a match grammar with Bracketed(). The sequence wrapping allows it to work, OneOf, AnyOf, etc would also work. It you remove the Sequence here, it breaks
| # The brackets might be empty for some functions... | ||
| optional=True, | ||
| ), | ||
| # parse_mode=ParseMode.GREEDY, |
| "FunctionContentsGrammar", | ||
| ), | ||
| ), | ||
| # parse_mode=ParseMode.GREEDY, |
Co-authored-by: Cameron <105471409+keraion@users.noreply.github.com>
keraion
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Function names shouldn't have touch after, function parameters should have touch before - as functions can be bare.
Fixes #5808
Fixes #5869
Fixes #5978
Are there any other side effects of this change that we should be aware of?
Hopefully no knock on effects. I reckon now that we have the function_contents segment, a few rules can be rewritten in a more elegant way - but this PR is already crowded enough. It may be worth a minor release due to the sheer size of the code change.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.