feat: ISSUE-228 random - document as Jitter #376
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liran2000 <liran2000@gmail.com>
|
@garyrussell hi, could you please review this ? |
|
It's on my TODO list. |
Signed-off-by: liran2000 <liran2000@gmail.com>
garyrussell
reviewed
Sep 11, 2023
src/main/java/org/springframework/retry/annotation/Backoff.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/retry/backoff/ExponentialRandomBackOffPolicy.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue 228, some users trying to use retry backoff policy with randomness, which is commonly referred to as Jitter.
By searching the documentation, the work Jitter does not appear in the random context. This may cause users to not be aware that Jitter is supported by the random capability and not using it, or struggle with searching the documentation.
Solution
Adding Jitter in the documentation when relevant.