Skip to content

Remove RelyingPartyRegistration deprecations #17329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2025
Merged

Remove RelyingPartyRegistration deprecations #17329

merged 4 commits into from
Jul 3, 2025

Conversation

ngocnhan-tran1996
Copy link
Contributor

Closes gh-17305

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 22, 2025
jzheaux
jzheaux requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ngocnhan-tran1996, this is a big help. I've left my feedback inline.

@jzheaux jzheaux self-assigned this Jun 24, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Jun 24, 2025
@jzheaux jzheaux mentioned this pull request Jun 24, 2025
Closed
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the gh-17305 branch 2 times, most recently from a3c2ca8 to d384044 Compare June 24, 2025 19:43
@ngocnhan-tran1996
Copy link
Contributor Author

ngocnhan-tran1996 commented Jun 24, 2025 •
edited
Loading

@jzheaux

Thanks for your feedback. I've updated it.

@ngocnhan-tran1996 @jzheaux
Remove RelyingPartyRegistration Deprecations
cf11ca5 
Closes spring-projectsgh-17309

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 @jzheaux
Update RelyingPartyRegistration JavaDoc
96c392d 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 @jzheaux
Remove OpenSamlRelyingPartyRegistration
2c650d9 
Issue spring-projectsgh-17309

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 @jzheaux
Remove Unused Method in TestOpenSamlObjects
0b449c3 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jul 3, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Jul 3, 2025

Thanks for the updates, @ngocnhan-tran1996! This will merge into main once the build finishes.

@jzheaux jzheaux enabled auto-merge (rebase) July 3, 2025 18:46
@jzheaux jzheaux merged commit 1583c90 into spring-projects:main Jul 3, 2025
6 checks passed
@jzheaux jzheaux mentioned this pull request Jul 3, 2025
Closed
@ngocnhan-tran1996 ngocnhan-tran1996 deleted the gh-17305 branch July 4, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.

Remove RelyingPartyRegistration deprecations
3 participants
@ngocnhan-tran1996 @jzheaux @spring-projects-issues