Skip to content

Use LdapName instead of DistinguishedName #17325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Use LdapName instead of DistinguishedName #17325

merged 1 commit into from
Jul 7, 2025

Conversation

therepanic
Copy link
Contributor

Resolves: #17301

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 21, 2025
jzheaux
jzheaux requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @therepanic! I've left some feedback inline.

In addition to that feedback, will you please place the ticket number in the description instead of the title, like so:

Use LdapName instead of DistinguishedName

Closes gh-17301

@jzheaux jzheaux self-assigned this Jun 24, 2025
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement type: breaks-passivity A change that breaks passivity with the previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Jun 24, 2025
@therepanic therepanic requested a review from jzheaux June 24, 2025 20:16
@therepanic
Copy link
Contributor Author

therepanic commented Jun 24, 2025 •
edited
Loading

I assume the build tests are failing not because of my changes?

@therepanic @jzheaux
Use LdapName instead of DistinguishedName
dcde627 
Closes spring-projectsgh-17301

Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jul 3, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Jul 3, 2025

So helpful, @therepanic, thank you again. This will merge into main once the build passes.

@jzheaux jzheaux merged commit fdf52f0 into spring-projects:main Jul 7, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jul 7, 2025

Thanks, @therepanic! This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.

Remove DistinguishedName Usage
3 participants
@therepanic @jzheaux @spring-projects-issues