ClearSiteDataHeaderWriter log is misleading #17126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
reviewed
May 21, 2025
There was a problem hiding this comment.
Good catch, @joaquinjsb! I've left some feedback inline. Also, will you please squash your commits and change the message to something closer to:
Log Request Mismatch Only When Mismatches
...src/main/java/org/springframework/security/web/header/writers/ClearSiteDataHeaderWriter.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/header/writers/ClearSiteDataHeaderWriter.java
Outdated
Show resolved
Hide resolved
|
should be good to go now, waiting for tests |
|
tests are failing but doesn't seem to be related to this change? |
Signed-off-by: Joaquin Santana <joaquinjsb@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is just a simple log typo which could be misleading, whether the requestmatcher matches or not, it's logging that it isn't.