Support add nested security configurers during builder initialization #17020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and working, thanks @kse-music! Any way I can help further to get this merged? |
|
Any timeline for getting this PR merged? (It blocks release of the next generation Kubernetes support in Vaadin) |
heruan
approved these changes
Jul 15, 2025
rwinch
added a commit
to kse-music/spring-security
that referenced
this pull request
Jul 21, 2025
A getter should not mutate state. This removes getConfigurersInInitializing in favor of inline code since this is just used once. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
rwinch
added a commit
to kse-music/spring-security
that referenced
this pull request
Jul 21, 2025
This just renames the Configurer names used in AbstractConfiguredSecurityBuilderTests to be more meaningful. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
rwinch
added a commit
to kse-music/spring-security
that referenced
this pull request
Jul 21, 2025
A getter should not mutate state. This removes getConfigurersInInitializing in favor of inline code since this is just used once. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
rwinch
added a commit
to kse-music/spring-security
that referenced
this pull request
Jul 21, 2025
This just renames the Configurer names used in AbstractConfiguredSecurityBuilderTests to be more meaningful. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
Closes spring-projectsgh-17011 Signed-off-by: DingHao <dh.hiekn@gmail.com>
A getter should not mutate state. This removes getConfigurersInInitializing in favor of inline code since this is just used once. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
This just renames the Configurer names used in AbstractConfiguredSecurityBuilderTests to be more meaningful. Issue spring-projectsgh-17020 spring-projectsgh-17011 Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17011