Implement UserDetailsPasswordService in JdbcUserDetailsManager #17071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junhyeok Lee <jhl221123@naver.com>
injae-kim
reviewed
May 9, 2025
| @@ -65,7 +66,8 @@ | |||
| * @author Luke Taylor | |||
Comment on lines
+624
to
+625
| @Override | ||
| public UserDetails updatePassword(UserDetails user, String newPassword) { |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public UserDetails updatePassword(UserDetails user, String newPassword) { | |
| @Override | |
| /** | |
| * comments like "updatePassword only when {@link #enableUpdatePassword} is true? | |
| */ | |
| public UserDetails updatePassword(UserDetails user, String newPassword) { |
nit. how about adding comment about updatePassword flag?
Signed-off-by: Junhyeok Lee <jhl221123@naver.com>
|
Thank you for the PR @jhl221123! This is now queued to be merged into main as soon as the build passes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements
UserDetailsPasswordServiceinJdbcUserDetailsManagerto allow password updates, controlled by a new flag.Changes:
updatePassword(UserDetails user, String newPassword)method.enableUpdatePasswordboolean property (default: false) and settersetEnableUpdatePassword(boolean).updatePasswordmethod logic updated:enableUpdatePasswordis true, it updates the user's password via updateUser.enableUpdatePasswordis false, it returns the originalUserDetailswithout performing any update.JdbcUserDetailsManagerTeststo verify both scenarios (updatePasswordWhenDisabledReturnOriginalUserandupdatePasswordWhenEnabledShouldUpdatePassword).Closes gh-16863