Skip to content

Remove APPLICATION_JSON_UTF8 usage #17070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

Remove APPLICATION_JSON_UTF8 usage #17070

merged 2 commits into from
May 7, 2025

Conversation

ngocnhan-tran1996
Copy link
Contributor

Issue: #17062

@ngocnhan-tran1996
Remove APPLICATION_JSON_UTF8 usage
cfac0f7 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996
Update javadoc
32403ce 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2025
@rwinch
Copy link
Member

rwinch commented May 7, 2025

Thanks @ngocnhan-tran1996 Did you review what the OAuth specs say around the media types? Can you provide links to where you verified that application/json was preferred over the UTF-8 equivalent?

@rwinch rwinch self-assigned this May 7, 2025
@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels May 7, 2025
@ngocnhan-tran1996
Copy link
Contributor Author

@rwinch

I have read OAuth 2.0 and OAuth 2.1, both of them don't mention specific header accept or specific charset. Please correct me if I have any mistakes.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 7, 2025
@rwinch rwinch added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release and removed status: feedback-provided Feedback has been provided labels May 7, 2025
@rwinch rwinch added this to the 7.0.0-M1 milestone May 7, 2025
@rwinch rwinch merged commit 48eb243 into spring-projects:main May 7, 2025
4 checks passed
@rwinch
Copy link
Member

rwinch commented May 7, 2025

Thanks for the Pull Request! This is now merged into main 😄

@rwinch rwinch mentioned this pull request May 7, 2025
Closed
@ngocnhan-tran1996 ngocnhan-tran1996 deleted the gh-17062 branch May 12, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @rwinch @spring-projects-issues