Fix the problem of not deserializing SwitchUserGrantedAuthority in Webflux #17064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
351a808 to
cab6817
Compare
jzheaux
requested changes
May 7, 2025
There was a problem hiding this comment.
Nice, @JohnNiang! Thanks for the quick turnaround.
In addition to my inline feedback will you please also:
- Add unit tests to demonstrate that the feature works
- Update the commit message to contains
Closes gh-17041on a separate line from the title like so:
Add SwitchUserGrantedAuthority to WebFlux Jackson Module
Closes gh-17041
web/src/main/java/org/springframework/security/web/jackson2/WebServletJackson2Module.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/jackson2/WebJackson2Module.java
Show resolved
Hide resolved
ad0485f to
8da8dee
Compare
jzheaux
approved these changes
May 12, 2025
Closes gh-17041 Signed-off-by: John Niang <johnniang@foxmail.com>
8da8dee to
fe2f8a1
Compare
jzheaux
approved these changes
May 23, 2025
|
Thanks, @JohnNiang, this is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the SwitchUserGrantedAuthorityMixIn annotations into WebJackson2Module instead of WebServlet Jackson2Module to fix the deserialization problem of SwitchUserGrantedAuthority in Webflux.
Fixes #17041