Skip to content

ClientRegistrations#fromIssuerLocation should not swallow 4xx exception messages #16993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

ClientRegistrations#fromIssuerLocation should not swallow 4xx exception messages #16993

merged 1 commit into from
Apr 29, 2025

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-16860

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 24, 2025
@jzheaux jzheaux self-assigned this Apr 29, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 29, 2025
@jzheaux jzheaux changed the title Consider ClientRegistrations.fromIssuerLocation to include failure information ClientRegistrations.fromIssuerLocation includes additional failure information in exception message Apr 29, 2025
@jzheaux jzheaux changed the title ClientRegistrations.fromIssuerLocation includes additional failure information in exception message ClientRegistrations#fromIssuerLocation includes additional failure information in exception message Apr 29, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 29, 2025

Thanks, @evgeniycheban! Will you please update the commit message to state what the commit is doing? Like maybe:

Add RestClient Failure Information to Exception Message

...

@evgeniycheban
Copy link
Contributor Author

Hi, @jzheaux I updated commit message.

@jzheaux jzheaux changed the title ClientRegistrations#fromIssuerLocation includes additional failure information in exception message ClientRegistrations#fromIssuerLocation should not swallow 4xx exception messages Apr 29, 2025
@jzheaux jzheaux added type: bug A general bug and removed type: enhancement A general enhancement labels Apr 29, 2025
@jzheaux jzheaux changed the base branch from main to 6.3.x April 29, 2025 19:25
@evgeniycheban @jzheaux
Add ClientRegistration's RestClient failed attempts information to ex…
a035fd7 
…ception message

Closes spring-projectsgh-16860

Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
@jzheaux jzheaux added this to the 6.3.10 milestone Apr 29, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 29, 2025 •
edited
Loading

I feel like this is a bug that ClientRegistrations is swallowing exception information. As such, I've rebased the PR onto 6.3.x so that folks on 6.3 and 6.4 also receive the benefits.

The result is that I changed the test assertion to be compatible with 6.3. When merging, I'll add a polish commit to make the assertion work with all three versions.

@jzheaux jzheaux merged commit 0e84f31 into spring-projects:6.3.x Apr 29, 2025
4 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Apr 29, 2025

Thanks again, @evgeniycheban. This plus f631a0f are now merged.

@jzheaux jzheaux mentioned this pull request Apr 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
6.3.10
Development

Successfully merging this pull request may close these issues.

ClientRegistrations.fromIssuerLocation does not include failure information
3 participants
@evgeniycheban @jzheaux @spring-projects-issues