Skip to content

Create CsrfCustomizer for SPA configuration #16966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Create CsrfCustomizer for SPA configuration #16966

merged 2 commits into from
May 27, 2025

Conversation

felhag
Copy link
Contributor

@felhag felhag commented Apr 18, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 18, 2025
@felhag felhag force-pushed the feature/114149-spa-csrf branch from fb322f9 to 8d09a9a Compare April 18, 2025 13:12
jzheaux
jzheaux requested changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, @felhag. It would be nice for the DSL to put this together for applications. I've left some feedback inline.

Note that I likely won't comment on this again until 6.5 releases, but I wanted to get you some feedback so that you aren't waiting on me.

@felhag felhag force-pushed the feature/114149-spa-csrf branch 2 times, most recently from d72b57d to ec53749 Compare April 24, 2025 11:45
@felhag
Copy link
Contributor Author

felhag commented Apr 24, 2025

Hey @jzheaux, thanks for your time. Processed your comments in a new commit (I assume it is squashed anyways when merged).

Renamed the method to just spa(). Since it was moved to the customizer I thought it was more consistent with other customizer methods.

And also updated the documentation.

@jzheaux jzheaux mentioned this pull request May 1, 2025
Closed
@jzheaux jzheaux self-assigned this May 7, 2025
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 7, 2025
@jzheaux jzheaux added this to the 7.0.x milestone May 7, 2025
@felhag felhag force-pushed the feature/114149-spa-csrf branch from ec53749 to 338d7f8 Compare May 15, 2025 07:13
@jzheaux jzheaux changed the title Create CsrfCustomizer for SPA configuration (#14149) Create CsrfCustomizer for SPA configuration May 23, 2025
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 May 23, 2025
felhag and others added 2 commits May 23, 2025 15:07
@felhag @jzheaux
Create CsrfCustomizer for SPA configuration
34cc363 
Closes spring-projectsgh-14149

Signed-off-by: Felix Hagemans <felixhagemans@gmail.com>
@jzheaux
Polish
eb879a1 
Issue spring-projectsgh-14149
@jzheaux jzheaux force-pushed the feature/114149-spa-csrf branch from 338d7f8 to eb879a1 Compare May 27, 2025 17:18
@jzheaux jzheaux enabled auto-merge (rebase) May 27, 2025 17:32
@jzheaux
Copy link
Contributor

jzheaux commented May 27, 2025

Thanks again for the contribution, @felhag! Now that 7.0 development is underway, we can merge this, which should happen once the build completes.

@jzheaux jzheaux merged commit 596449d into spring-projects:main May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@felhag @jzheaux @spring-projects-issues