Skip to content

Replace deprecated #check calls with #authorize #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

Replace deprecated #check calls with #authorize #16965

merged 2 commits into from
Jun 12, 2025

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-16936

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 18, 2025
@franticticktick
Copy link
Contributor

Hey @evgeniycheban , It would be nice if the verify method of the AuthorizationManager interface also call authorize.

@evgeniycheban
Copy link
Contributor Author

Hey @evgeniycheban , It would be nice if the verify method of the AuthorizationManager interface also call authorize.

Yeah, good catch, I must have missed that one.

@jzheaux jzheaux self-assigned this Apr 22, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2025
jzheaux
jzheaux requested changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I've left some feedback inline.

@evgeniycheban
Replace deprecated #check calls with #authorize
863e016 
Closes spring-projectsgh-16936

Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
@evgeniycheban
Copy link
Contributor Author

Hi, @jzheaux I've updated the PR.

@evgeniycheban evgeniycheban requested a review from jzheaux April 23, 2025 22:47
@franticticktick
Copy link
Contributor

It would be nice to make the same improvement for ReactiveAuthorizationManager as a separate commit.

@evgeniycheban
Copy link
Contributor Author

Hi, @jzheaux @franticticktick I've added a new commit replacing check calls with authorize for ReactiveAuthorizationManager.

@evgeniycheban evgeniycheban force-pushed the gh-16936 branch 2 times, most recently from a191f9f to 8f2a6aa Compare April 24, 2025 21:55
@evgeniycheban
ReactiveAuthorizationManager replace deprecated #check calls with #au…
1172581 
…thorize

Closes spring-projectsgh-16936

Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
@jzheaux jzheaux added this to the 7.0.0-M1 milestone Jun 12, 2025
@jzheaux jzheaux merged commit 092bbfc into spring-projects:main Jun 12, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 12, 2025

Thanks again, @evgeniycheban, also @franticticktick for your feedback. This is now merged into main.

@jzheaux jzheaux mentioned this pull request Jun 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

+1 more reviewer

@franticticktick franticticktick franticticktick left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.

Replace check calls with authorize
4 participants
@evgeniycheban @franticticktick @jzheaux @spring-projects-issues