Skip to content

Support Spring Data container types for AuthorizeReturnObject #16953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Support Spring Data container types for AuthorizeReturnObject #16953

merged 1 commit into from
May 29, 2025

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-15994

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2025
@evgeniycheban evgeniycheban force-pushed the gh-15994 branch 6 times, most recently from aa991e6 to fe6e014 Compare April 18, 2025 01:17
@jzheaux jzheaux added in: data An issue in spring-security-data type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 7, 2025
@jzheaux jzheaux added this to the 7.0.x milestone May 7, 2025
@jzheaux jzheaux self-assigned this May 7, 2025
jzheaux
jzheaux reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban, this looks great. I left a comment that I could use your clarification on.

@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label May 27, 2025
jzheaux
jzheaux requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban for the PR and for your comments. I've left my feedback inline.

@jzheaux jzheaux changed the title Consider supporting Spring Data container types for AuthorizeReturnObject Support Spring Data container types for AuthorizeReturnObject May 28, 2025
@evgeniycheban
Support Spring Data container types for AuthorizeReturnObject
318a463 
Closes spring-projectsgh-15994

Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
@evgeniycheban
Copy link
Contributor Author

@jzheaux I've updated the PR according to your feedback, thanks.

@evgeniycheban evgeniycheban requested a review from jzheaux May 29, 2025 22:20
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 29, 2025
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 May 29, 2025
@jzheaux jzheaux merged commit fd4f06a into spring-projects:main May 29, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented May 29, 2025

Thanks, @evgeniycheban! This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: data An issue in spring-security-data status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.

AuthorizeReturnObject should target the authorized object within Spring Data components
3 participants
@evgeniycheban @jzheaux @spring-projects-issues