Add caching headers to unmodified static resources #34614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per https://www.rfc-editor.org/rfc/rfc7232#section-4.1 The server generating a 304 response MUST generate any of the following header fields that would have been sent in a 200 (OK) response to the same request: Cache-Control, Content-Location, Date, ETag, Expires, and Vary. Signed-off-by: James Yuzawa <jtyuzawa@gmail.com>
127b2ec to
c8a082d
Compare
|
Thanks for your contribution @yuzawa-san ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with a CDN and noticed some interesting behavior. It was caching using the original Cache-Control max-age on the original 200, but when a refresh and 304 was returned by spring, the Cache-Control was missing, so the caching proxy used its default max-age (which was longer than my original max-age). I found this https://stackoverflow.com/questions/1587667/should-http-304-not-modified-responses-contain-cache-control-headers which pointed me at https://www.rfc-editor.org/rfc/rfc7232#section-4.1 which states: