Skip to content

ConfigurationFileFormat isn't copied in the description copy and is missing in the diff #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ConfigurationFileFormat isn't copied in the description copy and is missing in the diff #1693

wants to merge 1 commit into from

Conversation

YangSiJun528
Copy link
Contributor

The ConfigurationFileFormat introduced in gh-1682 is not handled in the copy constructor of MutableProjectDescription and in ProjectDescriptionDiff.

This PR adds the missing logic along with the corresponding tests.

@YangSiJun528
Handle ConfigurationFileFormat in description copy and diff
da6a033 
The ConfigurationFileFormat introduced in spring-iogh-1682 is not handled
in the MutableProjectDescription copy constructor or in
ProjectDescriptionDiff.

This commit adds the missing logic and corresponding tests.

Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 28, 2025
@mhalbritter mhalbritter self-assigned this Aug 28, 2025
@mhalbritter mhalbritter added type: bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 28, 2025
@mhalbritter mhalbritter added this to the 0.23.0 milestone Aug 28, 2025
@mhalbritter mhalbritter changed the title Handle ConfigurationFileFormat in description copy and diff ConfigurationFileFormat isn't copied in the description copy and is missing in the diff Aug 28, 2025
mhalbritter pushed a commit that referenced this pull request Aug 28, 2025
@YangSiJun528 @mhalbritter
Handle ConfigurationFileFormat in description copy and diff
663cbdd 
The ConfigurationFileFormat introduced in gh-1682 is not handled
in the MutableProjectDescription copy constructor or in
ProjectDescriptionDiff.

This commit adds the missing logic and corresponding tests.

See gh-1693

Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
@mhalbritter
Copy link
Contributor

Thanks @YangSiJun528 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: bug
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@YangSiJun528 @mhalbritter @spring-projects-issues