SA_FIELD_SELF_ASSIGNMENT false positive fix
#3553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not quite sure how this works but the test for spotbugs#2142 still passes
gtoison
commented
Jul 25, 2025
| orfl = orfl.next; | ||
| } | ||
|
|
||
| next = orfl; |
There was a problem hiding this comment.
Without the change in that PR, the state of the stack here is the same as if the while loop above wasn't there.
JuditKnoll
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CustomUserValueannotation disables the "iterative stack analysis" and this results in a false positive in the test case of this PR.Apparently removing the annotation is compatible with still using "user values" on the stack items
This should fix #2258