Fix CT_CONSTRUCTOR_THROW FP in private and public ctor with private ctor first
#3424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
commented
Apr 29, 2025
Comment on lines
+101
to
+106
| @Override | ||
| public void visit(Method obj) { | ||
| hadObjectConstructor = false; | ||
| super.visit(obj); | ||
| } | ||
|
|
There was a problem hiding this comment.
The fix to the issue is this function and deleting line 89. The other changes in this class are only cleanup. The bug is reported if hadObjectConstructor field is true in the second visit in reportConstructorThrow, which is set in the second visit, but it was only set back to false during the first visit.
Comment on lines
+11
to
+16
| private static boolean verify() throws IOException { | ||
| // Returns true if data entered is valid, else throws an Exception | ||
| // Assume that the attacker just enters invalid data, so this method always throws the exception | ||
| throw new IOException("Invalid data!"); | ||
| } | ||
|
|
There was a problem hiding this comment.
It looks like this code example and ConstructorThrowNegativeTest16 were completely the same. So I'm changing it slightly.
ThrawnCA
approved these changes
Apr 29, 2025
hazendaz
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup in the
ConstructorThrowdetector and fix #3417.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code