Skip to content

Conversation

ghernadi
Copy link
Contributor

Reproducer for #3324

Copy link
Collaborator

@JuditKnoll JuditKnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is indeed failing, but because of spotless. Can you please run gradlew spotlessApply to resolve the formatting issues?

@ghernadi
Copy link
Contributor Author

@JuditKnoll Thank you for the review. Am I supposed to mark the requested changes as "resolved" or is this the job of the reviewer (for example to verify if the changes indeed resolve the things mentioned)?

@JuditKnoll
Copy link
Collaborator

@JuditKnoll Thank you for the review. Am I supposed to mark the requested changes as "resolved" or is this the job of the reviewer (for example to verify if the changes indeed resolve the things mentioned)?

If you are absolutely sure, that the question is resolved, feel free to mark it, but you don't need to. I marked them as resolved.

Would you like to work on a fix for this issue, or you just wanted to report it with the reproducer?

@ghernadi
Copy link
Contributor Author

If you are absolutely sure, that the question is resolved, feel free to mark it, but you don't need to. I marked them as resolved.

Thanks, will (try to) remember for the next time! :)

Would you like to work on a fix for this issue, or you just wanted to report it with the reproducer?

In theory I would like to, but in practice I have no idea if I find time for that. I am more just a user of SpotBugs, have debugged it once and failed quite miserably in identifying the root cause. So I would be more than happy if someone more knowledgeable than me could take a look at fixing this issue.

@github-actions github-actions bot added the Stale label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants