Widen main method recognition according to JEP 445 #3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
commented
Mar 27, 2025
| @@ -315,8 +316,7 @@ private void checkStateForLeakedObligations(State state, Map<Obligation, State> | |||
| private void reportWarning(Obligation obligation, State state, StateSet factAtExit) { | |||
| String className = obligation.getClassName(); | |||
|
|
|||
| if (methodDescriptor.isStatic() && "main".equals(methodDescriptor.getName()) | |||
| && "([Ljava/lang/String;)V".equals(methodDescriptor.getSignature()) | |||
| if (MemberUtils.isMainMethod(xmethod) | |||
There was a problem hiding this comment.
Originally the methodDescriptor field is checked with the MethodDescriptor type, which has no function for checking the visibility (or at least I could not find it easily).
The function containing this check, reportWarning() is only called from analyzeMethod() in line 278:
In the same method before this call, the
xmethod field is set from methodDescriptor in line 235:So I think using
xmethod here instead of methodDescriptor should be okay.
gtoison
approved these changes
Mar 28, 2025
hazendaz
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main method recognition is stuck in times before JEP 445 for several detectors. This PR fixes this problem by creating and calling one of the two applicable util methods.
I could not find any other usages of the string
"main"in detectors, so hopefully all main method checks are addressed.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code