Do not report US_USELESS_SUPPRESSION_ON_METHOD on generated methods
#3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
reviewed
Mar 25, 2025
spotbugsTestCases/src/classSamples/lombokAddSuppressFBWarnings/README.md
Outdated
Show resolved
Hide resolved
| @@ -32,6 +36,10 @@ | |||
| */ | |||
| public final class MemberUtils { | |||
|
|
|||
| private static final String LOMBOK_GENERATED_TYPE = "Llombok/Generated;"; | |||
There was a problem hiding this comment.
There are other Generated annotations for methods. You don't want to add those as well?
There was a problem hiding this comment.
I was wondering about that too, see:
this would effectively set the
FOUND_IN_SYNTHETIC_METHOD property for all these generated methods and adjust (increase) the priority (meaning less important) so the bug instances might be silenced.
I'm not sure what might be the consequences to be honest
There was a problem hiding this comment.
Thanks for highlighting it. It's a bit strange, that this one is handled a bit differently, but I think it could be okay like this.
There was a problem hiding this comment.
I think that a reasonable plan would be to release a first version only considering Lombok's @Generated and, if nothing breaks, expand to other similar annotations in a subsequent version
JuditKnoll
approved these changes
Mar 26, 2025
JuditKnoll
approved these changes
Apr 1, 2025
hazendaz
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3350 and should improve the change from #3353