Cleanup: remove unnecessary throws declarations from methods #3220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
commented
Dec 3, 2024
| @@ -367,8 +367,6 @@ private void updateBugCollection(Project findBugsProject, Reporter bugReporter, | |||
| // props | |||
| st.newPoint("storeBugCollection"); | |||
| FindbugsPlugin.storeBugCollection(project, resultCollection, monitor); | |||
| } catch (IOException e) { | |||
| FindbugsPlugin.getDefault().logException(e, "Error performing SpotBugs results update"); | |||
| } catch (CoreException e) { | |||
| FindbugsPlugin.getDefault().logException(e, "Error performing SpotBugs results update"); | |||
| } | |||
There was a problem hiding this comment.
The IOException was catched from the FindbugsPlugin.storeBugCollection() method, which does not throw this exception. Also, the two catch blocks are the same.
hazendaz
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary throws declarations from methods, where the method body doesn't throw the listed exception, or a more general exception already listed.
See the issues in SonarCloud.