ThrowingExceptions detector crash when parsing method signature containing nested generics #3268
Conversation
- Depecrate SignatureParser and reverted the attempt to let it support generic methods - Copied SignatureParser.getArguments() into GenericSignatureParser - Clarified GenericSignatureParser.compareSignatures() javadoc - Added changelog entry
| @@ -33,6 +33,8 @@ | |||
| * A simple class to parse method signatures. | |||
| * | |||
| * @author David Hovemeyer | |||
| * | |||
| * @deprecated This signature parser does not support generics, use GenericSignatureParser instead. | |||
There was a problem hiding this comment.
Can you also add deprecated annotation to match javadoc? Or if that only applies to generics, it should us deprecated javadoc annotation.
There was a problem hiding this comment.
I've added the annotation.
This is a digression but I think we should consider requiring JDK soon (when it's GA), so we can use JEP-484's classfile API: among other things it has a signature parser and it would be a good replacement for these limited parsers.
There was a problem hiding this comment.
I've added the annotation.
This is a digression but I think we should consider requiring JDK soon (when it's GA), so we can use JEP-484's classfile API: among other things it has a signature parser and it would be a good replacement for these limited parsers.
We just updated to Java 11 requirement, let us bump it to Java 17 and then to 21 first. After that we might consider to require Java 25 (next LTS), which is however not released yet... So I don't expect this API be available soon for SpotBugs.
As reported in #3267 ThrowingExceptions causes errors with some methods with generics.
See #2072
See #2040
This should fix #3267